Time column accounts for destination's time zone

This commit is contained in:
Tony Bark 2026-08-24 05:51:47 -04:00
parent e1c39aa457
commit bf420b7480
3 changed files with 81 additions and 33 deletions

View file

@ -26,13 +26,26 @@ struct AmtrakDateFormatting {
return isoFormatter.date(from: isoString) return isoFormatter.date(from: isoString)
} }
func time(from isoString: String?, timeZone: TimeZone? = nil) -> String? { func time(from isoString: String?, timeZone: TimeZone?, relativeTo otherZone: TimeZone? = nil) -> String? {
guard let isoString, !isoString.isEmpty, let date = isoFormatter.date( guard let isoString, !isoString.isEmpty, let date = isoFormatter.date(
from: isoString) else { from: isoString) else {
return nil return nil
} }
timeFormatter.timeZone = timeZone timeFormatter.timeZone = timeZone
return timeFormatter.string(from: date)
let formatted = timeFormatter.string(from: date)
guard
let timeZone,
let otherZone,
timeZone.identifier != otherZone.identifier,
let abbreviation = timeZone.abbreviation(for: date)
else {
return formatted
}
return "\(formatted) \(abbreviation)"
} }
func localTime(timeZone: TimeZone?) -> String { func localTime(timeZone: TimeZone?) -> String {

View file

@ -51,12 +51,12 @@ struct ContentView: View {
} }
Table(rows) { Table(rows) {
TableColumn("Time", value: \TrainStatusRow.arrival) TableColumn("Time", value: \TrainStatusRow.time)
TableColumn("Number", value: \TrainStatusRow.trainNum) TableColumn("Number", value: \TrainStatusRow.trainNum)
TableColumn("", value: \TrainStatusRow.presence.rawValue) TableColumn("", value: \TrainStatusRow.presence.rawValue)
TableColumn("Train", value: \TrainStatusRow.routeName) TableColumn("Train", value: \TrainStatusRow.train)
TableColumn("To", value: \TrainStatusRow.destination) TableColumn("To", value: \TrainStatusRow.to)
TableColumn("From", value: \TrainStatusRow.origin) TableColumn("From", value: \TrainStatusRow.from)
TableColumn("Status") { TableColumn("Status") {
(row: TrainStatusRow) in (row: TrainStatusRow) in
ZStack { ZStack {
@ -68,7 +68,7 @@ struct ContentView: View {
) )
} }
} }
TableColumn("Track", value: \TrainStatusRow.platform) TableColumn("Track", value: \TrainStatusRow.track)
}.frame(minWidth: 600) }.frame(minWidth: 600)
.overlay(alignment: .bottomTrailing) { .overlay(alignment: .bottomTrailing) {
if isLoading { if isLoading {
@ -136,6 +136,8 @@ struct ContentView: View {
return return
} }
var zoneCache: [String: TimeZone?] = [code: lookup.timeZone]
var newRows: [TrainStatusRow] = [] var newRows: [TrainStatusRow] = []
for number in lookup.trainNumbers { for number in lookup.trainNumbers {
let trains = try await client.fetchAllTrainStatus(num: number) let trains = try await client.fetchAllTrainStatus(num: number)
@ -144,12 +146,13 @@ struct ContentView: View {
where: { $0.code == code where: { $0.code == code
}, },
)?.platform )?.platform
newRows await newRows
.append( .append(
trainStatus( trainStatus(
for: train, for: train,
atStationCode: code, atStationCode: code,
timeZone: lookup.timeZone timeZone: lookup.timeZone,
zoneCache: &zoneCache
) )
) )
} }
@ -187,30 +190,65 @@ struct ContentView: View {
} }
} }
func trainStatus(for train: Train, atStationCode code: String, timeZone: TimeZone?) -> TrainStatusRow { func trainStatus(
for train: Train,
atStationCode code: String,
timeZone: TimeZone?,
zoneCache: inout [String: TimeZone?]
) async -> TrainStatusRow {
let leg = train.stations?.first { $0.code == code } let leg = train.stations?.first { $0.code == code }
let stationName = leg?.name ?? unknown let stationName = leg?.name ?? unknown
let arrival = amtrakDate.time(from: leg?.arr, timeZone: timeZone) ?? amtrakDate.time( let track = leg?.platform ?? ""
var originZone: TimeZone?
if let orgCode = train.origCode {
originZone = await fetchTimeZone(
forStationCode: orgCode,
cache: &zoneCache
)
}
let time = amtrakDate.time(
from: leg?.arr,
timeZone: timeZone,
relativeTo: originZone
) ?? amtrakDate.time(
from: leg?.schArr, from: leg?.schArr,
timeZone: timeZone) timeZone: timeZone,
let depature = amtrakDate.time(from: leg?.dep, timeZone: timeZone) ?? amtrakDate.time( relativeTo: originZone
from: leg?.schDep, )
timeZone: timeZone)
currentStation = stationName currentStation = stationName
localTimeZone = timeZone localTimeZone = timeZone
return TrainStatusRow( return TrainStatusRow(
trainID: train.trainID, trainID: train.trainID,
time: time ?? "",
trainNum: train.trainNum, trainNum: train.trainNum,
routeName: train.routeName, presence: leg?.status ?? .unknown, // Yeah... It's a little confusing
status: isOnTime(arr: leg?.arr, schArr: leg?.schArr), train: train.routeName,
platform: leg?.platform ?? "", to: train.destName,
arrival: arrival ?? "", from: train.origName,
departure: depature ?? "", status: isOnTime(
origin: train.origName, arr: leg?.arr,
destination: train.destName, schArr: leg?.schArr
presence: leg?.status ?? .unknown // Yeah... It's a little confusing ),
track: track.isEmpty ? "" : track
) )
} }
func fetchTimeZone(forStationCode code: String, cache: inout [String: TimeZone?]) async -> TimeZone? {
if let cached = cache[code] {
return cached
}
let zone: TimeZone?
do {
let response = try await client.fetchStation(code: code)
zone = response[code]?.tz.flatMap(TimeZone.init(identifier:))
} catch {
zone = nil
}
return zone
}
} }

View file

@ -90,18 +90,15 @@ typealias TrainResponse = [String: [Train]]
typealias StationResponse = [String: StationMeta] typealias StationResponse = [String: StationMeta]
struct TrainStatusRow: Identifiable { struct TrainStatusRow: Identifiable {
var id: String { var id: String { trainID }
trainID
}
var trainID: String var trainID: String
var time: String
var trainNum: String var trainNum: String
var routeName: String
var status: TrainLateness
var platform: String
var arrival: String
var departure: String
var origin: String
var destination: String
var presence: StationStatus var presence: StationStatus
var train: String
var to: String
var from: String
var status: TrainLateness
var track: String
} }