From 475e31594344e1393a2db48b729a543ba20f17aa Mon Sep 17 00:00:00 2001 From: Patryk Obara Date: Sun, 29 Dec 2019 16:15:45 +0100 Subject: [PATCH] Stop silencing 'throw' warnings in MSVC Warning C4290 informs users, that MSVC ignores throw specification. This is very good warning, because 'throw' specifications were faulty design and got deprecated in C++11 and REMOVED from the language in C++20. Throw specifications were replaced by much better 'noexcept' keyword, which allows for compile-time checks, unlike 'throw', which might silently inject exception 'std::unexpected'. --- include/control.h | 1 - include/setup.h | 1 - 2 files changed, 2 deletions(-) diff --git a/include/control.h b/include/control.h index 6d1dffbd..15553dfb 100644 --- a/include/control.h +++ b/include/control.h @@ -22,7 +22,6 @@ #ifdef _MSC_VER #pragma warning ( disable : 4786 ) -#pragma warning ( disable : 4290 ) #endif #ifndef DOSBOX_PROGRAMS_H diff --git a/include/setup.h b/include/setup.h index 68f4c135..bf70309f 100644 --- a/include/setup.h +++ b/include/setup.h @@ -22,7 +22,6 @@ #ifdef _MSC_VER #pragma warning ( disable : 4786 ) -#pragma warning ( disable : 4290 ) #endif