valter/dosbox-staging
1
0
Fork 0
Code Releases Activity

Bring back C++11 foreach loop in fmopl

Browse source 
Upstream replaced C++11 code with C++ "almost-equivalents", when merging
code from MAME project.

Reverting this fixes few warnings (comparison of signed and unsigned
integer in this case) and makes it slightly easier for the compiler
to unroll the nested loops.
This commit is contained in:
Patryk Obara 2020-03-27 14:14:29 +01:00 • committed by Patryk Obara
parent 06805b28fb
commit 5983e820c4
1 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/hardware/mame/fmopl.cpp
View file

@ -1766,19 +1766,12 @@ void FM_OPL::ResetChip()
for(int i = 0xff ; i >= 0x20 ; i--) WriteReg(i,0);
/* reset operator parameters */
// for(OPL_CH &CH : P_CH)
for(int ch = 0; ch < sizeof(P_CH)/ sizeof(P_CH[0]); ch++)
{
OPL_CH &CH = P_CH[ch];
// for(OPL_SLOT &SLOT : CH.SLOT)
for(int slot = 0; slot < sizeof(CH.SLOT) / sizeof(CH.SLOT[0]); slot++)
{
OPL_SLOT &SLOT = CH.SLOT[slot];
for (OPL_CH &ch : P_CH) {
for (OPL_SLOT &slot : ch.SLOT) {
/* wave table */
SLOT.wavetable = 0;
SLOT.state = EG_OFF;
SLOT.volume = MAX_ATT_INDEX;
slot.wavetable = 0;
slot.state = EG_OFF;
slot.volume = MAX_ATT_INDEX;
}
}
#if BUILD_Y8950