valter/dosbox-staging
1
0
Fork 0
Code Releases Activity

Silence static analysis false-positive garbage value

Browse source 
Clang static analyzer returned a false-positive issue in line 671:

The right operand of '<' is a garbage value

Variables needed to be moved up, because otherwise initialization
crosses to the next case.
This commit is contained in:
Patryk Obara 2019-11-23 23:49:22 +01:00 • committed by Patryk Obara
parent f105697165
commit 723dfdbe46
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/hardware/vga_xga.cpp
View file

@ -574,6 +574,8 @@ void XGA_DrawWait(Bitu val, Bitu len) {
if(!xga.waitcmd.wait) return;
Bitu mixmode = (xga.pix_cntl >> 6) & 0x3;
Bitu srcval;
Bitu chunksize = 0;
Bitu chunks = 0;
switch(xga.waitcmd.cmd) {
case 2: /* Rectangle */
switch(mixmode) {
@ -645,8 +647,6 @@ void XGA_DrawWait(Bitu val, Bitu len) {
break;
case 0x02: // Data from PIX_TRANS selects the mix
Bitu chunksize;
Bitu chunks;
switch(xga.waitcmd.buswidth&0x60) {
case 0x0:
chunksize=8;
@ -661,7 +661,7 @@ void XGA_DrawWait(Bitu val, Bitu len) {
chunksize=16;
if(len==4) chunks=2;
else chunks = 1;
break;
break;
case 0x60: // undocumented guess (but works)
chunksize=8;
chunks=4;