valter/dosbox-staging
1
0
Fork 0
Code Releases Activity
4424 commits 2 branches 0 tags 8.7 MiB
Commit graph

3780 commits

Author SHA1 Message Date
Patryk Obara
4add527371 Fix wrong function name in the exception log 
Bug report: https://sourceforge.net/p/dosbox/bugs/518/
 2019-12-04 06:11:01 +01:00
David Reid
84588c50bd Bump dr_wav to v0.11.2 
Fixes:
- https://github.com/mackron/dr_libs/issues/84
- https://github.com/mackron/dr_libs/issues/83
- https://github.com/mackron/dr_libs/issues/82
- https://github.com/mackron/dr_libs/issues/81
- https://github.com/mackron/dr_libs/issues/80
- https://github.com/mackron/dr_libs/issues/79
- https://github.com/mackron/dr_libs/issues/78
- https://github.com/mackron/dr_libs/issues/77
- https://github.com/mackron/dr_libs/issues/76
- https://github.com/mackron/dr_libs/issues/75
 2019-12-03 06:35:00 +01:00
David Reid
6b5a5acc9a Bump dr_mp3 to v0.5.4 
Fixes:
- https://github.com/mackron/dr_libs/issues/86
- https://github.com/mackron/dr_libs/issues/85
 2019-12-03 06:35:00 +01:00
David Reid
1866b4d295 Bump dr_flac to v0.12.3 
Fixes:
- https://github.com/mackron/dr_libs/issues/93
- https://github.com/mackron/dr_libs/issues/92
- https://github.com/mackron/dr_libs/issues/91
- https://github.com/mackron/dr_libs/issues/90
- https://github.com/mackron/dr_libs/issues/89
- https://github.com/mackron/dr_libs/issues/88
- https://github.com/mackron/dr_libs/issues/87
 2019-12-03 06:35:00 +01:00
krcroft
1f2ff70463 Ensure alloca is not defined before defining 2019-12-03 06:35:00 +01:00
krcroft
01a61a33f8 Remove ineffective consts and indicate unused variables 2019-12-03 06:35:00 +01:00
krcroft
d23f31fbe3 Avoid unecessary float-to-double promotion, and cleanup 2019-12-03 06:35:00 +01:00
krcroft
b55b43f543 Use PRIuPTR and define it for Windows GCC 64-bit 2019-12-03 05:12:28 +01:00
Patryk Obara
7d21bb1408 Move definition out of autoconfig 2019-12-03 05:12:28 +01:00
krcroft
7e3c4d3945 Harmonize refactoring of switch statement 2019-12-03 05:12:28 +01:00
krcroft
8a5a539f9a Cleanup printf types and explicitly state unused vars 2019-12-03 05:12:28 +01:00
krcroft
e5981c3b8e Fix uninitized scalar access 2019-12-03 05:12:28 +01:00
krcroft
d1a1932a07 Fix uninitized pointer accesses 2019-12-03 05:12:28 +01:00
Patryk Obara
f3b8bff3f5 Remove unused private field in device_EMM 2019-11-29 06:27:14 +01:00
Patryk Obara
e95b6e7063 Remove unused private field in fatFile 2019-11-29 06:27:14 +01:00
Patryk Obara
7afc052550 Silence "unused-const-variable" warning 
This register dump looks useful, but it was never used for anything…
 2019-11-29 06:27:14 +01:00
Patryk Obara
6325c995d6 Fix "unused-variable" warning 2019-11-29 06:27:14 +01:00
Patryk Obara
5ff1fcd604 Fix "misleading-indentation" warnings 
GCC helpfully indicates, that:

warning: this ‘if’ clause does not guard (…) this statement, but
the latter is misleadingly indented as if it were guarded by the ‘if’.

Also, improve readability while we're touching these lines.
 2019-11-29 06:27:14 +01:00
Patryk Obara
59edc4d9b5 Change the length of version field in infobox 
Otherwise, infobox looks broken when version string has more
than 8 characters.
 2019-11-29 06:27:14 +01:00
Patryk Obara
e831d0b090 Remove pointless switch causing warnings 2019-11-29 06:27:14 +01:00
Patryk Obara
19b8902db3 Fix a resource leak 
This bug was detected via Coverity static analysis:
Variable tempfile going out of scope leaks the storage it points to.

The leak happens when invalid keyboard layout file is being loaded:

  $ touch xx.kl
  $ dosbox .
  C:\>keyb xx
 2019-11-28 21:06:20 +01:00
Patryk Obara
301d7c3423 Merge branch 'svn/trunk' r4296 2019-11-26 18:37:09 +01:00
Peter Veenstra
1521b7ad7d Fix bug #519 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4296
 2019-11-26 16:52:04 +00:00
Peter Veenstra
f1608a2509 Fix bug #520 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4295
 2019-11-26 15:30:53 +00:00
krcroft
eaeb001b17 Play into subsequent track(s) if playback length exceeds the the current track 
Issue reported by Dagar and Pr3tty F1y, and confirmed as a bug by ripsaw8080.
Thank you!

This fixes the GoG release of Betrayal at Krondor which (either due to CD mastering
issues or a faulty rip), requests playback of a given track at the tail end
of the prior track.

In debugging and performing this fix, many debug messages were improved as well
as making some small small code adjustments, such as using iterators to point to
individual tracks (track->attribute) instead of using the tracks array
(tracks[track -1].attribute).
 2019-11-24 17:34:54 +01:00
Patryk Obara
6c42f3adf8 Fix several unused-private-field warnings 2019-11-24 17:14:32 +01:00
Patryk Obara
ef40533d22 Silence 2 switch warnings 2019-11-24 17:14:32 +01:00
Patryk Obara
618ab5ea08 Remove several unused variables in zmbv 2019-11-24 17:14:32 +01:00
Patryk Obara
bdee95848e Silence a number of switch warnings in zmbv 2019-11-24 17:14:32 +01:00
Patryk Obara
723dfdbe46 Silence static analysis false-positive garbage value 
Clang static analyzer returned a false-positive issue in line 671:

The right operand of '<' is a garbage value

Variables needed to be moved up, because otherwise initialization
crosses to the next case.
 2019-11-24 17:14:32 +01:00
Patryk Obara
f105697165 Silence a number of switch warnings in vga_xga 
In total, 28 warnings are removed by adding these few default cases.
 2019-11-24 17:14:32 +01:00
Patryk Obara
64671a888c Avoid passing null to strcat 
Static analysis indicated an issue, when line was being passed as 2nd
argument to strcat:

Null pointer passed as an argument to a 'nonnull' parameter

Replace repeated strcat with creating a formatted string and use
the opportunity to do a small format cleanup.
 2019-11-24 17:14:32 +01:00
Patryk Obara
b344344821 Properly fix warnings about unused variable 
A workaround with no-op assignment fools the compiler and static
analyzer, but the proper fix cleans up this code as well.
 2019-11-24 17:14:32 +01:00
Patryk Obara
ef144e4bca Merge branch 'svn/trunk' r4294 2019-11-23 18:41:05 +01:00
Peter Veenstra
f923a8e644 a=a can trigger warnings as well. This should be hopefully do the trick. 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4294
 2019-11-22 07:28:27 +00:00
Patryk Obara
cdc193170c Merge branch 'svn/trunk' r4293 2019-11-21 20:53:21 +01:00
Peter Veenstra
db51b63554 Remove some old code and do an a=a to trick a compiler in non-debug mode 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4293
 2019-11-20 07:17:12 +00:00
Peter Veenstra
8cb2e08f31 Refinements of commit 4291, so that precission can be specified as well and less fixed defines are used 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4292
 2019-11-19 16:16:06 +00:00
Peter Veenstra
01fe58047e Try to solve the Bitu formatting warning on all supported platforms (both 32 and 64 bit). Did a few places. Still a lot to go. Changed default display of Bitu to be unsigned instead of signed. 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4291
 2019-11-18 21:08:57 +00:00
Patryk Obara
ea06a145b6 Fix several printf format warnings 2019-11-16 04:31:19 +01:00
Patryk Obara
8824504474 Silence several sometimes-uninitialized warnings 
GCC compiler reports these as:

warning: variable (…) is used uninitialized whenever switch default
is taken
 2019-11-16 04:31:19 +01:00
Patryk Obara
97ded39c2e Remove unused variable 2019-11-16 04:31:19 +01:00
Patryk Obara
d63849ea72 Remove unused function 2019-11-16 04:31:19 +01:00
Patryk Obara
41126f8ff9 Fix unused-function warning 
This function is used only inside x86 ifdef, so move it to prevent the
warning. Also, use this opportunity to improve readability a bit.
 2019-11-16 04:31:19 +01:00
Patryk Obara
ce1deb1516 Silence a number of switch warnings 
Avoid "default" case when only 1-2 enumarations are missing.
 2019-11-16 04:31:19 +01:00
Patryk Obara
ae6c1e9a89 Fix order of includes in Windows-specific files 
These files assume, that WIN32 is defined by compiler or MSVC project
file, when in MSYS2 and MinGW environments, it is defined in config.h
and appears after dosbox.h is included, which in turn is included by
associated header (cdrom.h in this case).

Fixes: #42
 2019-11-14 23:17:54 +01:00
Patryk Obara
4e65c8f69f Add asserts to prevent a potential bug 
Use C++11 static_assert to assure, that code behaves correctly; if
Chip or Channel structs will be changed to non-std layout or a different
first fields will be introduced, that will invalidate the offset
calculation.

Additionally, add asserts to prevent possibility of introducing a bug
when offset stored in one the tables is 0.
 2019-11-12 17:13:01 +01:00
Patryk Obara
1e95311081 Add cases for missing SynthMode enumerations 
Silence compiler warnings:
enumeration value 'sm2Percussion' not handled in switch [-Wswitch]
enumeration value 'sm3Percussion' not handled in switch [-Wswitch]
 2019-11-12 17:13:01 +01:00
Patryk Obara
43170ff1c2 Merge branch 'svn/trunk' r4284 2019-11-12 16:13:13 +01:00
Peter Veenstra
fab69cb4c7 Stuff written to the console needs a cariage return since 4114. Thanks for spotting this dreamer_. 
Imported-from: https://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk@4284
 2019-11-12 13:31:23 +00:00